Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(vats): Remove makeBridgeTargetKit from prepareTransferTools #9471

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

gibson042
Copy link
Member

@gibson042 gibson042 commented Jun 7, 2024

#8624 (comment)

makeBridgeTargetKit can be more general than "IBC transfer", and is already pulled in separately by vat-transfer.js

@gibson042 gibson042 added the force:integration Force integration tests to run on PR label Jun 7, 2024
@gibson042 gibson042 requested a review from michaelfig June 7, 2024 19:22
Copy link

cloudflare-workers-and-pages bot commented Jun 7, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 9b2bfbb
Status: ✅  Deploy successful!
Preview URL: https://c515f30d.agoric-sdk.pages.dev
Branch Preview URL: https://gibson-9059-vtransfer-tools.agoric-sdk.pages.dev

View logs

@michaelfig michaelfig changed the title [DO NOT MERGE] Dummy PR to test #8624 vtransfer prepareTransferTools simplification refactor(vats): Remove makeBridgeTargetKit from prepareTransferTools Jun 10, 2024
@michaelfig michaelfig marked this pull request as draft June 10, 2024 17:17
#8624 (comment)

makeBridgeTargetKit can be more general than "IBC transfer", and
is already pulled in separately by vat-transfer.js
@michaelfig michaelfig force-pushed the gibson-9059-vtransfer-tools-simplification branch from af0348e to 9b2bfbb Compare June 10, 2024 17:51
@michaelfig michaelfig marked this pull request as ready for review June 10, 2024 17:51
@michaelfig michaelfig added automerge:no-update (expert!) Automatically merge without updates and removed force:integration Force integration tests to run on PR labels Jun 10, 2024
Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely! LGTM.

@mergify mergify bot merged commit 71db129 into master Jun 10, 2024
73 of 80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants